dash-spv/src/sync/filters/manager.rs (1)

151-156: Verify scan_start calculation when wallet_committed_height > 0 but less than wallet_birth_height.

If wallet_committed_height is between 1 and wallet_birth_height - 1 (e.g., due to data corruption or manual reset), then wallet_birth_height.max(wallet_committed_height + 1) correctly resolves to wallet_birth_height, so this is safe. However, this means a committed height below birth height is silently ignored — if this scenario is unexpected, a warning log could help debugging.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@dash-spv/src/sync/filters/manager.rs` around lines 151 - 156, The calculation
of scan_start using wallet_birth_height.max(wallet_committed_height +
1).max(header_start_height) can silently ignore a non-zero
wallet_committed_height that is less than wallet_birth_height; add an explicit
check before computing scan_start: if wallet_committed_height > 0 &&
wallet_committed_height < wallet_birth_height, emit a warning log (via the
existing logger used in this module) indicating the unexpected committed height
and the values of wallet_committed_height and wallet_birth_height, then proceed
with the current max-based computation; reference the variables scan_start,
wallet_committed_height, wallet_birth_height, and header_start_height to locate
where to insert the check and logging.

key-wallet-manager/src/wallet_manager/process_block.rs (1)

184-197: Consider adding test coverage for filter_committed_height.

The existing test_synced_height test validates synced_height but doesn't exercise the new filter_committed_height methods or verify the interaction between them (e.g., that update_filter_committed_height only advances synced_height when the new height exceeds it).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@key-wallet-manager/src/wallet_manager/process_block.rs` around lines 184 -
197, Add a new async test (e.g., test_filter_committed_height) that constructs a
WalletManager<ManagedWalletInfo> (Network::Testnet), asserts initial values for
synced_height() and filter_committed_height(), then call
update_filter_committed_height with increasing heights and verify that
filter_committed_height() advances accordingly and that synced_height() only
advances when the new filter committed height exceeds the current synced_height
(and never decreases when a smaller value is applied). Also include a case where
update_filter_committed_height is called with a lower height to ensure neither
filter_committed_height nor synced_height decreases, and a case where advancing
filter_committed_height causes synced_height to be bumped to the same value.

key-wallet-manager/src/wallet_manager/process_block.rs (1)

183-197: Consider adding test coverage for the new filter_committed_height methods.

The existing test_synced_height test validates synced_height behavior but doesn't cover the new filter_committed_height / update_filter_committed_height methods. A small test verifying the decoupled behavior (e.g., that update_filter_committed_height doesn't regress synced_height) would increase confidence.

💡 Example test

#[tokio::test]
async fn test_filter_committed_height() {
    let mut manager: WalletManager<ManagedWalletInfo> = WalletManager::new(Network::Testnet);
    assert_eq!(manager.filter_committed_height(), 0);

    // Advance synced_height via process_block simulation
    manager.update_synced_height(1000);
    assert_eq!(manager.synced_height(), 1000);

    // filter_committed_height should be independent
    assert_eq!(manager.filter_committed_height(), 0);

    // Committing a lower filter height should NOT regress synced_height
    manager.update_filter_committed_height(500);
    assert_eq!(manager.filter_committed_height(), 500);
    assert_eq!(manager.synced_height(), 1000); // unchanged

    // Committing a higher filter height should also advance synced_height
    manager.update_filter_committed_height(2000);
    assert_eq!(manager.filter_committed_height(), 2000);
    assert_eq!(manager.synced_height(), 2000);
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@key-wallet-manager/src/wallet_manager/process_block.rs` around lines 183 -
197, Add a new unit test mirroring test_synced_height to cover the new
filter_committed_height behavior on WalletManager<ManagedWalletInfo>: verify
initial filter_committed_height() == 0, that calling update_synced_height(...)
does not change filter_committed_height, that
update_filter_committed_height(lower) updates filter_committed_height without
regressing synced_height(), and that update_filter_committed_height(higher)
advances both filter_committed_height() and synced_height() as expected; place
the test alongside test_synced_height in process_block.rs and reference the
WalletManager, update_synced_height, update_filter_committed_height,
filter_committed_height, and synced_height methods.